Open
Conversation
Reviewer's Guide by SourceryThis pull request implements several changes to improve the build process, enhance the snapshot warning functionality, update dependencies, and introduce a new spellcheck feature. The changes span across multiple files, including scripts, workflows, and configuration files. Sequence diagram for snapshot warning insertionsequenceDiagram
participant Script as insert_snapshot_warning.js
participant JSDOM
participant VirtualConsole
participant FileSystem
Script->>VirtualConsole: Create VirtualConsole instance
VirtualConsole->>VirtualConsole: Suppress warnings
loop for each HTML file
Script->>JSDOM: Load HTML file with virtualConsole
JSDOM->>Script: Return DOM
Script->>JSDOM: Create style element
Script->>JSDOM: Insert WARNING_HTML at body start
Script->>FileSystem: Write updated HTML file
end
Script->>Console: Log 'Done!' on success
Script->>Console: Log error on failure
Updated class diagram for spellcheck scriptclassDiagram
class Spellcheck {
+String BASE_REF
+String[] ASPELL_OPTS
+int MIN_WORD_SIZE
+makeDict(words)
+lines(text)
}
class ExecP {
+execP(command)
}
class FileSystem {
+writeFile(file, content)
}
Spellcheck --> ExecP : uses
Spellcheck --> FileSystem : uses
note for Spellcheck "New script for spellchecking HTML files"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
This was missed in 961f269.
There is no use of Abstract Closures as async function bodies in ecma262 itself. This PR is a prereq to allow the JSPI specification to pass in an AC.
... because it's talking about a string literal in *Java*. See #3310 (comment)
(PR #2548 unfolded many invocations of Yield, but didn't change the accompanying Note-steps.)
(Make it consistent with PR #2592)
Co-authored-by: jhnaldo <jhpjhp0223@gmail.com> Co-authored-by: Michael Ficarra <mficarra@shapesecurity.com> Co-authored-by: Kevin Gibbons <bakkot@gmail.com>
From [proposal-array-from-async](https://github.com/tc39/proposal-array-from-async). Co-authored-by: <jschoi@jschoi.org> Co-authored-by: Linus Groh <mail@linusgroh.de> Co-authored-by: Michael Ficarra <github@michael.ficarra.me>
#3745) Co-authored-by: Kevin Gibbons <bakkot@gmail.com> Co-authored-by: Nicolò Ribaudo <nribaudo@igalia.com>
Editorial: Short-circuit return/throw on if-else step Editorial: Remove else on short-circuit if/else-if step Editorial: Inline if-else on true/false return Editorial: Inline if-else on integer return Editorial: Inline if-else on Number value return Editorial: Invert condition on inline if-else Editorial: Inline if-else on long if condition Co-authored-by: Jungwoong Kim <jungwngkim@gmail.com> Co-authored-by: Michael Ficarra <github@michael.ficarra.me> Co-authored-by: Kevin Gibbons <bakkot@gmail.com>
…es need not keep the Promise alive (#3764)
…the source text of primitive values (#3714)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )